gadget: emmc syntax support #14533
Merged
gadget: emmc syntax support #14533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Meulengracht
force-pushed
the
feature/gadget-emmc-syntax
branch
from
fb01951
to
bed97d5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14533 +/- ##
==========================================
+ Coverage 78.95% 78.97% +0.02%
==========================================
Files 1084 1085 +1
Lines 146638 147221 +583
==========================================
+ Hits 115773 116272 +499
- Misses 23667 23723 +56
- Partials 7198 7226 +28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bboozzoo
reviewed
Oct 7, 2024
bboozzoo
approved these changes
Oct 28, 2024
alfonsosanchezbeato
approved these changes
Nov 6, 2024
| // -*- Mode: Go; indent-tabs-mode: t -*- | ||
|
|
||
| /* | ||
| * Copyright (C) Canonical Ltd |
There was a problem hiding this comment.
We do not put the year here anymore? Is this a new policy?
There was a problem hiding this comment.
From a legal standponit we don't have to, we should slowly migrate to year-less headers, i wanted to bring this up at the sprint but forgot
…ing the error message just repeating twice. rename the validEMMCNames back again to be consistent
Meulengracht
force-pushed
the
feature/gadget-emmc-syntax
branch
from
9958871
to
5b10081
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first PR of 3 (likely) in the road to emmc support.
The first PR (this one)
Next PRs:
REF: SNAPDENG-32142