Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Freezes macaroonbakery #134

Merged
merged 1 commit into from
Dec 8, 2023
Merged

fix: Freezes macaroonbakery #134

merged 1 commit into from
Dec 8, 2023

Conversation

gruyaume
Copy link
Collaborator

@gruyaume gruyaume commented Dec 8, 2023

Description

The end to end tests are currently failing because of an issue with the new version of macaroonbakery (1.3.3) which is imported by Juju. Here we freeze it to 1.3.2.

TypeError: Descriptors cannot be created directly.
If this call came from a _pb2.py file, your generated code is out of date and must be regenerated with protoc >= 3.19.0.
If you cannot immediately regenerate your protos, some other possible workarounds are:
 1. Downgrade the protobuf package to 3.20.x or lower.
 2. Set PROTOCOL_BUFFERS_PYTHON_IMPLEMENTATION=python (but this will use pure-Python parsing and will be much slower).

Reference

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have bumped the version of the library

@gruyaume gruyaume requested a review from a team as a code owner December 8, 2023 12:22
@gruyaume gruyaume changed the title fix: Freezes macaroonbakery (imported by Juju) fix: Freezes macaroonbakery Dec 8, 2023
Copy link
Contributor

@gatici gatici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest to insert it into file in alphabetical order.

@gruyaume gruyaume merged commit 3c1a8d8 into main Dec 8, 2023
18 checks passed
@gruyaume gruyaume deleted the dev-macaroon branch December 8, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants