Updating node version in the action from 12 to 16; trying to elimite …

…set-output from workflow
canonical · Oct 11, 2023 · 6651924 · 6651924
1 parent de356d2
commit 6651924
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/.github/actions/ec2-github-runner/action.yml b/.github/actions/ec2-github-runner/action.yml
@@ -83,5 +83,5 @@ outputs:
       EC2 Instance Id of the created runner.
       The id is used to terminate the EC2 instance when the runner is not needed anymore.
 runs:
-  using: node12
+  using: node16
   main: ./dist/index.js
diff --git a/.github/workflows/integration-tests.yaml b/.github/workflows/integration-tests.yaml
@@ -11,9 +11,6 @@ jobs:
   start-runner:
     name: Start self-hosted EC2 runner
     runs-on: ubuntu-latest
-    outputs:
-      label: ${{ steps.start-ec2-runner.outputs.label }}
-      ec2-instance-id: ${{ steps.start-ec2-runner.outputs.ec2-instance-id }}
     steps:
       - name: Checkout
         uses: actions/checkout@v4
@@ -48,11 +45,16 @@ jobs:
                 } 
               } 
             ]
+      - name: Set vars
+        id: set-vars
+        run: |
+          echo "LABEL=${{ steps.start-ec2-runner.outputs.label }}" >> "$GITHUB_OUTPUT"
+          echo "EC2_INSTANCE_ID=${{ steps.start-ec2-runner.outputs.ec2-instance-id }}" >> "$GITHUB_OUTPUT"
 
   integration-tests:
     name: Integration tests
     needs: start-runner
-    runs-on: ${{ needs.start-runner.outputs.label }}
+    runs-on: ${{ needs.start-runner.set-vars.outputs.LABEL }}
     steps:
       - name: Checkout
         uses: actions/checkout@v4
@@ -122,5 +124,5 @@ jobs:
         with:
           mode: stop
           github-token: "${{ secrets.GH_PERSONAL_ACCESS_TOKEN }}"
-          label: ${{ needs.start-runner.outputs.label }}
-          ec2-instance-id: ${{ needs.start-runner.outputs.ec2-instance-id }}
+          label: ${{ needs.start-runner.set-vars.outputs.LABEL }}
+          ec2-instance-id: ${{ needs.start-runner.set-vars.outputs.EC2_INSTANCE_ID }}