-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Go tutorial and reference #723
Conversation
fa851bb
to
47903ac
Compare
47903ac
to
e74cf0c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked at the tutorial, I think it is a good start
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a relatively new user, I tried to follow the tutorial but failed (there isn't a go-framework profile). But I still read through the tutorial thoroughly. There are some nitpicking comments, but mostly are my thoughts on naming consistency and content organisation. See comments inline.
Thank you very much for your review!. With respect to not being able to run it, it should be related to the need to refresh to the latest/edge channel (using for example |
Co-authored-by: Michael DuBelko <[email protected]>
Co-authored-by: Michael DuBelko <[email protected]>
Co-authored-by: Michael DuBelko <[email protected]>
Co-authored-by: Michael DuBelko <[email protected]>
Co-authored-by: Michael DuBelko <[email protected]>
Co-authored-by: Michael DuBelko <[email protected]>
Co-authored-by: Michael DuBelko <[email protected]>
Co-authored-by: Michael DuBelko <[email protected]>
Co-authored-by: Michael DuBelko <[email protected]>
Co-authored-by: Michael DuBelko <[email protected]>
Co-authored-by: Michael DuBelko <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting back so soon, @javierdelapuente! I have some requests for small language changes in the newer text. Nothing major. I think the rest is fine to publish. Do you have plans to address/close the remaining suggestions from everyone else?
Odd, GitHub split my suggestions into separate reviews. Not sure why. |
Co-authored-by: Michael DuBelko <[email protected]>
Co-authored-by: Michael DuBelko <[email protected]>
I have closed all conversations, as all of them were already addresses/replied. |
@tigarmo Shall we merge? |
Adds a tutorial and reference docs for the Go extension