-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new python3.10-venv slices when bare in flask-framework extension #606
Conversation
Why is it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Btw, the docs (https://documentation.ubuntu.com/rockcraft/en/stable/tutorials/getting-started-with-flask/#chisel-the-rock) should be updated as I'm expecting the resulting rock to now be more than 15% smaller
Indeed, but not that this %age (like the size also provided in this tutorial) might change at any time due to new packages, and dependencies. |
It was my impression, from this PR, that if you use a |
You understood properly, but the size of the images depends on the size of the dependencies installed and the size of the files the slices are setting. This can change overtime. |
Ofc it can, but in that case, we wouldn't be stating any sizes anywhere, and we are (64MB , and then 15% reduction). You do agree that, with your changes, the size reduction will no longer be 15% right? If that's true, then the doc needs fixing |
Sure agree, that was just a side note. |
Waiting on canonical/chisel-releases#271 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the spread test needs an easy fix (remove the rockcraft.yaml)
For reference, the ubuntu 22.04 base leads to a 65MB image, while the bare base image (with python3.10) leads to a 44MB image size |
Thanks a lot! Does anyone else want to look into this before I sync it with main & merge? |
@tigarmo please wait for a check on the documentation. Is https://documentation.ubuntu.com/rockcraft/en/stable/reference/extensions/flask-framework/ up to date after this merge? If the rockcraft.yaml accurate? |
I didn't change anything about the user experience. The documentation update needed was about the size reduction of the produced chiseled rock. |
Using the new
python3.11-venv
slice to reduce the image of the generated rock when base isbare
usingflask-framework
anddjango-framework
extensions.How to test:
Install a build of rockcraft using this branch, you need to have
docker
installed tooYou can also test using the tutorial (follow the chiseling part of the tutorial):
https://documentation.ubuntu.com/rockcraft/en/latest/tutorials/getting-started-with-flask/