refactor: use default BuildPlanner #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mr-cal
force-pushed
the
work/CRAFT-2824-default-build-planner-2
branch
from
2719e31 to
af341a7
Compare
mr-cal
commented
May 29, 2024
tigarmo
force-pushed
the
work/CRAFT-2824-default-build-planner-2
branch
2 times, most recently
from
b607c53 to
f3cdf58
Compare
|
failures are unrelated (I guess |
tigarmo
approved these changes
Jul 11, 2024
sergiusens
approved these changes
Jul 11, 2024
Signed-off-by: Callahan Kovacs <[email protected]>
Signed-off-by: Callahan Kovacs <[email protected]>
Signed-off-by: Callahan Kovacs <[email protected]>
tigarmo
force-pushed
the
work/CRAFT-2824-default-build-planner-2
branch
from
f3cdf58 to
771ebda
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a test PR for canonical/craft-application#326, to see if the default BuildPlanner will work for rockcraft.
There are a few pre-requisite commits to be compatible with the latest craft-application.
I wasn't able to get pydantic to use this upstream validator but everything else seems to be in working order.
(CRAFT-2824)