chore: merge 'hotfix/1.3' back into 'main' #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tigarmo
commented
Apr 22, 2024
tigarmo
commented
- Have you signed the CLA?
* change pebble dir in 24.04 from /.rock/bin to /usr/bin * add a test for "exec pebble services"
Some archs don't have wheels for some of the dependencies (like pygit2).
mr-cal
approved these changes
Apr 22, 2024
cmatsuoka
approved these changes
Apr 23, 2024
| @@ -50,6 +51,19 @@ parts: | |||
| organize: | |||
| "usr/bin/fuse-overlayfs": "libexec/rockcraft/fuse-overlayfs" | |||
|
|
|||
| libgit2: # part came from snapcraft@5fbaab144842f | |||
| source: https://github.com/libgit2/libgit2/archive/refs/tags/v1.7.1.tar.gz | |||
There was a problem hiding this comment.
Shallow-cloning the repository at this specific tag could be better than downloading the tarball.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.