Merge craft-application update into main #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigarmo
changed the title
Is this the one that updates craft-application to 2.4.0? |
yes |
cmatsuoka
approved these changes
Apr 5, 2024
lengau
approved these changes
Apr 5, 2024
The BuildPlanner has the project's base, build-base and platform declarations, and does all the validation related to those fields.
This cleans-up the code related to functionality that is now implemented upstream. This includes: - registering application plugins; - package-repositories installation (including overlays). It also updates some tests to latest features, like "parallel_build_count".
The brunt of the update is updating usages of platform/build-for to the build plan. This largely affects the image and package services, but the semantics should be unchanged because it's the same data just delivered differently.
The problem is this: the flask extension currently adds a 'build-base' if the 'base' is 'bare' but the 'build-base' is undeclared, and a 'platforms' entry if it's missing, but this behavior breaks with the new version of craft-application because the BuildPlanner processes the yaml _before_ the extensions are applied, and the planner cannot work without a build-base or platform description. The extension behavior of adding a 'build-base' and a 'platforms' item needs to be reviewed: we probably don't want to support this. In the meantime, this commit fixes only the projects that are executed in spread.
lengau
force-pushed
the
feature/craft-application
branch
from
17beef2 to
3c0c48d
Compare
|
Rebased on main, should be ready to rebase-merge when CI completes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The update to the latest craft-application update was done over time in this
feature/craft-applicationbranch, which is now ready to be integrated back into main. Only the latest commit needs to be reviewed because we might as well update to the very new2.4.0- all other commits have already been reviewed in various past PRs.