feat: use debian arch in platforms #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigarmo
force-pushed
the
CRAFT-2106-platform-deb-arch
branch
2 times, most recently
from
0b765a5 to
9617a1f
Compare
This commit puts Rockcraft in line with other craft tools: the architectures listed in the platforms are in Debian format, and we convert when necessary (such as when fetching images from a Docker registry). As a side-effect, we also drop the "build variant" notion from the platforms - currently this variant is only used when fetching/creating images, so keep the variant logic localized to rockcraft.oci.
tigarmo
force-pushed
the
CRAFT-2106-platform-deb-arch
branch
from
9617a1f to
23b64dc
Compare
tigarmo
changed the title
tigarmo
commented
Oct 18, 2023
cjdcordeiro
requested changes
Oct 19, 2023
sergiusens
approved these changes
Oct 19, 2023
cmatsuoka
reviewed
Oct 19, 2023
This way both ``project`` and ``oci`` can make use of it
cjdcordeiro
approved these changes
Oct 20, 2023
There was a problem hiding this comment.
noice!! very clean.
I left a few non-blocking nitpicks.
Despite the approval, I'd still recommend double checking https://github.com/canonical/rockcraft/pull/380/files#r1364486923 just to be sure Umoci is working well for non-amd64 archs
|
@cjdcordeiro regarding the umoci arch: as we discussed, I updated the code to use GOARCH as that is most likely the expected format (based on umoci's code and the OCI spec) and next week I'll confirm that assumption with a manual test on a non-standard arch |
tigarmo
added a commit
that referenced
this pull request
Oct 25, 2023
This commit puts Rockcraft in line with other craft tools: the architectures listed in the platforms are in Debian format, and we convert to GOARCH when necessary (such as when fetching images from a Docker registry or creating empty ones with umoci). As a side-effect, we also drop the "build variant" notion from the platforms - currently this variant is only used when fetching/creating images, so keep the variant logic localized to rockcraft.oci.
tigarmo
added a commit
that referenced
this pull request
Oct 26, 2023
This commit puts Rockcraft in line with other craft tools: the architectures listed in the platforms are in Debian format, and we convert to GOARCH when necessary (such as when fetching images from a Docker registry or creating empty ones with umoci). As a side-effect, we also drop the "build variant" notion from the platforms - currently this variant is only used when fetching/creating images, so keep the variant logic localized to rockcraft.oci.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit puts Rockcraft in line with other craft tools: the
architectures listed in the platforms are in Debian format, and we
convert when necessary (such as when fetching images from a Docker
registry).
As a side-effect, we also drop the "build variant" notion from the
platforms - currently this variant is only used when fetching/creating
images, so keep the variant logic localized to rockcraft.oci.
Fixes #370, #358