Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: drop environment expansion #376

Merged
merged 1 commit into from
Oct 16, 2023
Merged

refactor: drop environment expansion #376

merged 1 commit into from
Oct 16, 2023

Conversation

tigarmo
Copy link
Collaborator

@tigarmo tigarmo commented Oct 11, 2023

  • Have you signed the CLA?

@tigarmo tigarmo marked this pull request as ready for review October 11, 2023 20:33
@tigarmo tigarmo requested review from cmatsuoka and lengau October 11, 2023 20:33
tigarmo
tigarmo commented Oct 11, 2023
View reviewed changes
requirements-dev.txt Outdated Show resolved Hide resolved
cmatsuoka
cmatsuoka approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@cmatsuoka cmatsuoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! -- don't forget to update the requirements list before landing

@tigarmo
refactor: drop environment expansion
b290990 
Expansion of project environment is now done in craft-application;
reorganize the code so that we still do Rockcraft-specific
transformations (apply extensions and add the Pebble part), but we
can remove the expansion-related code.
@tigarmo tigarmo force-pushed the drop-variable-expansion branch from ad23db6 to b290990 Compare October 16, 2023 11:27
@tigarmo tigarmo merged commit 790a068 into feature/craft-application Oct 16, 2023
14 checks passed
@tigarmo tigarmo deleted the drop-variable-expansion branch October 16, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lengau lengau lengau approved these changes

@cmatsuoka cmatsuoka cmatsuoka approved these changes

Assignees
No one assigned
Labels
do-not-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tigarmo @cmatsuoka @lengau