Migrate lifecycle commands #366

tigarmo · 2023-10-02T15:14:39Z

Have you signed the CLA?

With the move to craft-application, the base instances got renamed from base-instance-rockcraft to base-instance-buildd, so update the regex.

tests/integration/plugins/test_python_plugin.py

tools/docs/gen_cli_docs.py

tests/spread/general/destructive/task.yaml

rockcraft/environment.py

rockcraft/services/package.py

tests/integration/test_application.py

tests/integration/services/test_lifecycle.py

tests/integration/test_application.py

cmatsuoka

This is a large changeset but the guided tour was very informative and the implementation seems consistent with no obvious issues. Just added a few nitpicking notes.

tests/integration/conftest.py

tests/testing/project.py

requirements-dev.txt

sergiusens

if the nits are made to bits, then all good

This removes all commands in rockcraft.commands.lifecycle, in preference of the default commands from craft-application.

The unit tests are dropped too. Most of them test basic funcionality that is already test in craft-application, and the remaining rockcraft-specific features (like package repositories) are already tested in tests.unit.services.test_lifecycle.

This is a bit more involved because the previous tests were heavily tied to the previous code, so it's done as a separate commit. There is no change in functionality, just some cleaning-up and updating of the code.

lengau

This is very impressive work!

tigarmo force-pushed the migrate-lifecycle-commands branch 4 times, most recently from 0a391aa to a3644f1 Compare October 2, 2023 22:19

spread: don't delete base instances

6df0d4b

With the move to craft-application, the base instances got renamed from base-instance-rockcraft to base-instance-buildd, so update the regex.

tigarmo force-pushed the migrate-lifecycle-commands branch from a3644f1 to 14bc847 Compare October 4, 2023 12:42

tigarmo marked this pull request as ready for review October 4, 2023 14:00

tigarmo commented Oct 4, 2023

View reviewed changes

tests/integration/plugins/test_python_plugin.py Outdated Show resolved Hide resolved

tigarmo commented Oct 4, 2023

View reviewed changes

tools/docs/gen_cli_docs.py Outdated Show resolved Hide resolved

tigarmo added the run-manual-spread Run large/flaky spread tests label Oct 4, 2023

tigarmo requested review from cmatsuoka and lengau October 4, 2023 14:48

tigarmo added the do-no-squash label Oct 5, 2023