[MISC] Add experimental max_connections config #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragomirp
force-pushed
the
max-connections
branch
from
df9ce4c to
b48fb11
Compare
dragomirp
force-pushed
the
max-connections
branch
from
b48fb11 to
ff5fa50
Compare
dragomirp
commented
May 20, 2024
| @@ -1468,7 +1468,7 @@ def _restart(self, event: RunWithLock) -> None: | |||
| return | |||
|
|
|||
| try: | |||
| for attempt in Retrying(wait=wait_fixed(3), stop_after_delay=stop_after_delay(300)): | |||
| for attempt in Retrying(wait=wait_fixed(3), stop=stop_after_delay(300)): | |||
dragomirp
commented
May 20, 2024
Comment on lines
+1550
to
+1555
| # Use config value if set, calculate otherwise | ||
| if self.config.experimental_max_connections: | ||
| max_connections = self.config.experimental_max_connections | ||
| else: | ||
| max_connections = max(4 * os.cpu_count(), 100) | ||
|
|
There was a problem hiding this comment.
Doing this only here would trigger a restart on deploy with experimental_max_connections. I can also inject it in the config file, by changing the internal library, but I would rather keep it KISS.
dragomirp
commented
May 20, 2024
Comment on lines
+405
to
+408
| experimental_max_connections: | ||
| type: int | ||
| description: | | ||
| [EXPERIMENTAL] Force set max_connections. |
There was a problem hiding this comment.
Should we add some kind of validation here?
There was a problem hiding this comment.
should we maybe enforce an upper limit?
There was a problem hiding this comment.
It's a footgun config.
dragomirp
requested review from
marceloneppel,
taurus-forever and
lucasgameiroborges
delgod
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds experimental support for force setting max_connections.