fix: [DPE-6234] Disable general_log and plugin audit_log_filter #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The config option general_log is not compatible with the real productions due to dumping all SQL queries to the general.log: https://dev.mysql.com/doc/refman/8.0/en/query-log.html > ... The server writes information to this log when clients connect or > disconnect, and it logs each SQL statement received from clients... In the past, it was a necessary evil as we had to keep record all connects/disconnects from the clients for security reasons. Nowadays we have audit_log plugin enabled by default, therefor no need to pay such a high performance price and struggle from the general.log size #523 (comment) > 33GB /var/snap/charmed-mysql/common/var/log/mysql/archive_general/general.log-20241212_0013 Additionally, we are working on the logs compression spec (separate topic). --- While working here, we have noticed unnecessary enabled plugin audit_log_filter which also produces log files in /var/lib/mysql. Disabling it for now, as it is not necessary for audit_log plugin announcer functionality. We will consider re-enabling the plugin without rush in https://warthogs.atlassian.net/browse/DPE-6235
Otherwise MySQL didn't start as the option is unknown until plugin is loaded.
taurus-forever
requested review from
paulomach,
shayancanonical,
carlcsaposs-canonical and
sinclert-canonical
carlcsaposs-canonical
approved these changes
Dec 16, 2024
sinclert-canonical
approved these changes
Dec 16, 2024
shayancanonical
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The config option general_log is not compatible with the real productions due to the massive SQL queries dump into the general.log: https://dev.mysql.com/doc/refman/8.0/en/query-log.html
In the past, it was a necessary evil as we had to keep all records about user's connects/disconnects for the security reasons. Nowadays we have audit_log plugin enabled by default, therefor no need to pay such a high performance price and struggle from the general.log size
#523 (comment)
Additionally, we are working on the logs compression spec (separate topic).
While working here, we have noticed unnecessary enabled plugin audit_log_filter which also produces log files in /var/lib/mysql. Disabling it for now, as it is not necessary for audit_log plugin announcer functionality.
We will consider re-enabling the plugin without rush in https://warthogs.atlassian.net/browse/DPE-6235
Solution