add preflight check (without app status check and move primary check) #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Issue Before implementing upgrades we need the "bones" of the upgrade code implemented by Carl ## Solution 1. Copy over bones from carl 2. change opensearch specific changes to VM specific changes 3. add notes for future PRs ## Future PRs 1. Implement basic preflight check and tests 2. Implement upgrades 3. Add int-tests in for upgrades --------- Co-authored-by: Carl Csaposs <[email protected]>
|
apologizes for the delay; planning to review after implementing pre-upgrade-check structure in opensearch (https://warthogs.atlassian.net/browse/DPE-4128) @MiaAltieri please let me know if you'd like me to review earlier |
There was a problem hiding this comment.
here's the pre-upgrade check shared code canonical/opensearch-operator#262 (runs pre-upgrade-check on action and automatically after juju refresh before first unit upgrade)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
There is no pre-flight check for upgrades
Solution
Copying over old-preflight check to new upgrade implementation
Summary + Future PRs
My goal is to simplify PR review and separate out:
In order to separate out the new pre-flight checks with the old ones. I will make two PRs: