[Hardware sync] - deployment form - add periodic hardware sync checkbox ui

[petermakowski]

Done

• add periodic hardware sync checkbox to the deployment form
  • redux and api integration will be done separately https://github.com/canonical-web-and-design/app-tribe/issues/780 - this will include additional tests

Screenshots

QA

MAAS deployment

To run this branch you will need access to one of the following MAAS deployments:

• Karura
• Bolla
• A development MAAS
• A local snap MAAS (this will not usually have machines)

Running the branch

You can run this branch by:

• Serving with dotrun
• Building in a development MAAS

QA steps

• go to any machine that can be deployed, e.g. on bolla: /MAAS/r/machine/7c7ya3/summary
• verify that the checkbox is displayed properly (it's disabled for now)

Fixes

Fixes: canonical-web-and-design/app-tribe/issues/779

Launchpad issue

Related Launchpad maas issue in the form lp#number.

Backports

In general, please propose fixes against master rather than release branches (e.g. 2.7), unless the fix is only applicable for that specific release. Please apply backport labels to the PR (e.g. "Backport 2.7") for the appropriate releases to target.

Only bug and security fixes should be backported, new features should only land in master.

[huwshimi]

A couple of QA things:

In the design the help text is indented, like this:

Also this has extra space around the tooltip:

Whereas the design is much tighter (which also aligns the tooltip arrow with the icon):

[petermakowski]

In the design the help text is indented

Thanks! I filed a bug for this in react-components, but I'll use a custom element in the meantime like we do for other checkboxes on this page.

• Input help text doesn't match vanillaframework specs react-components#748
• Input checkbox is not configured to handle controls react-components#749

[petermakowski]

Whereas the design is much tighter (which also aligns the tooltip arrow with the icon):

Updated this.

[huwshimi]

Hi @petermakowski I went to take another look at this, but it now appears to include a bunch of unrelated commits.

[petermakowski]

Hi @petermakowski I went to take another look at this, but it now appears to include a bunch of unrelated commits.

Rebased, should be all good now.

[petermakowski]

These changes have been already merged in #3759