Show instance root disk size correctly on instance list #14511
+18
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes an instance on an offline node show as `unavailable` instead of a more general `Error`. An alternative to this would be introducing a new api Status for unavailable instances. Signed-off-by: hamistao <[email protected]>
Signed-off-by: hamistao <[email protected]>
Signed-off-by: hamistao <[email protected]>
When driver does not support getting the volume usage, we are returning prematurely and not getting the volume total size, even when it is possible. Signed-off-by: hamistao <[email protected]>
This helps get correct VM disk total size. Signed-off-by: hamistao <[email protected]>
hamistao
force-pushed
the
instance_metrics_on_list
branch
from
752fbf9
to
0ad2e26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aims to get instance root disk sizes correctly, as it currently often shows as 0 or null, as reported by #14277.
This is still missing handling container disk sizes when the
sizeconfig key is not set.