-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QEMU: disable unneeded options #546
base: latest-edge
Are you sure you want to change the base?
QEMU: disable unneeded options #546
Conversation
Signed-off-by: Simon Deziel <[email protected]>
Signed-off-by: Simon Deziel <[email protected]>
Signed-off-by: Simon Deziel <[email protected]>
Signed-off-by: Simon Deziel <[email protected]>
Signed-off-by: Simon Deziel <[email protected]>
Signed-off-by: Simon Deziel <[email protected]>
Signed-off-by: Simon Deziel <[email protected]>
Signed-off-by: Simon Deziel <[email protected]>
Signed-off-by: Simon Deziel <[email protected]>
Signed-off-by: Simon Deziel <[email protected]>
Signed-off-by: Simon Deziel <[email protected]>
Signed-off-by: Simon Deziel <[email protected]>
We only use SPICE. Signed-off-by: Simon Deziel <[email protected]>
Signed-off-by: Simon Deziel <[email protected]>
https://wiki.qemu.org/Documentation/Networking#VDE: > Unless you specifically know that you want to use VDE, it is probably not the > right backend to use. Signed-off-by: Simon Deziel <[email protected]>
Signed-off-by: Simon Deziel <[email protected]>
This vvfat feature allows exporting a directory from to host to a guest. The directory view is built once at boot time. Not something we use in our snap. Signed-off-by: Simon Deziel <[email protected]>
The size of the actual compiled binaries didn't change much:
But the reduction of dependencies is rather pleasant to look at:
The |
This was tested by installing the snap in my host and then in a VM running on it:
This confirms that importing an image worked so |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL that Multipass disables some of those options (https://github.com/canonical/multipass/blob/main/snap/snapcraft.yaml#L236-L279):
--disable-gnutls
--disable-libiscsi
--disable-nettle
--disable-vvfat
@tomponline is now a good time to consider this for merging? |
ill save this for 6.3 |
The list of options was obtained by running the following in a git clone of QEMU's source:
Note:
--disable-tcg
is still not possible as theqemu-ovmf-secureboot
part still depends on it as before (#454 (comment)).