Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get tests passing on plucky #290

Merged
merged 4 commits into from
Dec 9, 2024

Conversation

Perfect5th
Copy link
Contributor

Twisted changed a little bit - it used to run cleanFailure on Failure instances in the defer code but no longer does in the version available in plucky (python3-twisted 24.10).

This change does cleanFailure in the FakeReactor we use for some tests. This allows tests that rely on catching and flushing Failures to succeed.

@Perfect5th
Copy link
Contributor Author

One way to test, created a plucky container using dev_lxc (https://pypi.org/project/dev-lxc/) and run the tests, with and without this change:

dev_lxc create --config .dev-lxc/config.yaml plucky
dev_lxc shell plucky
make check

@wck0 wck0 self-requested a review December 4, 2024 23:38
Copy link
Contributor

@wck0 wck0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests passed on plucky, noble, jammy, and focal.

One in-line comment asking to review some grammar.

Also, codecov seems confused. Not sure how to address that...

landscape/lib/testing.py Outdated Show resolved Hide resolved
@Perfect5th
Copy link
Contributor Author

I'm not too worried about codecov. If anything, we should disable it in favour of TiCS.

@Perfect5th Perfect5th merged commit 1273983 into canonical:main Dec 9, 2024
5 checks passed
@Perfect5th Perfect5th deleted the fix-plucky-tests branch December 9, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants