Fix: monitor-only not being set properly when false/no passed in config #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srunde3
requested changes
Nov 25, 2024
srunde3
requested changes
Nov 27, 2024
| val = False | ||
| for f in FALSY_VALUES: | ||
| val = convert_arg_to_bool(f) | ||
| self.assertFalse(val) |
There was a problem hiding this comment.
We'll want this in the loop - it's OK if the test fails after the first failing instance. We don't have to worry about subtests.
You also won't need to initialize val, then.
| "Error. Invalid boolean provided in config or parameters. " | ||
| + "Defaulting to False.", | ||
| ) | ||
| self.assertFalse(val) |
| val = True | ||
| for t in TRUTHY_VALUES: | ||
| val = convert_arg_to_bool(t) | ||
| self.assertTrue(val) |
srunde3
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual Testing
Verify Bug
Verify Fix