fix: add manage-sources-list-d CLI option (LP:2077360) ; refactor: optparse to argparse for CLI options #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or landscape-client
srunde3
reviewed
Sep 5, 2024
| "--include-manager-plugins", | ||
| metavar="PLUGINS", | ||
| default="", | ||
| help="A comma-separated list of manager plugins " | ||
| "to enable in addition to the defaults.", | ||
| ) | ||
| parser.add_option( | ||
| parser.add_argument( |
There was a problem hiding this comment.
What's the anticipated usage here? Something like --manage-sources-list-d false?
There was a problem hiding this comment.
Yep, so a user can do
--manage-sources-list-d false
--manage-sources-list-d true
--manage-sources-list-d
the last one will also set it to true
srunde3
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor optparse to argparse. Should be mostly a drop-in replacement except for positional arguments (which were previously ignored).
https://bugs.launchpad.net/landscape-client/+bug/2077360
To create similar functionality for
--manage-sources-list-das described in the report, landscape-config will parse the terminal command with an optional argument for t/f values.