Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPE-5565] Release notes for 195/149 release #263

Closed
wants to merge 14 commits into from

Conversation

deusebio
Copy link
Contributor

Release notes for the upcoming release.

I would still like to tune a bit the community message and some other bits around. @grobbie maybe you can craft the main message for the community.

@deusebio deusebio requested review from grobbie and izmalk October 21, 2024 15:13
Copy link
Contributor

@izmalk izmalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are some suggestions on how to improve the existing release notes. Feel free to apply them how you see fit. We can discuss the new structure on the sprint or after.
If no structural changes are wanted, then I'd recommend just adding empty lines after headings, renaming "General updates" sections, and moving some of its contents to the Notes section at the end.

docs/reference/r-releases/r-rev185_149.md Outdated Show resolved Hide resolved
docs/reference/r-releases/r-rev185_149.md Outdated Show resolved Hide resolved
docs/reference/r-releases/r-rev185_149.md Outdated Show resolved Hide resolved
docs/reference/r-releases/r-rev185_149.md Outdated Show resolved Hide resolved
docs/reference/r-releases/r-rev185_149.md Outdated Show resolved Hide resolved
docs/reference/r-releases/r-rev185_149.md Outdated Show resolved Hide resolved
docs/reference/r-releases/r-rev185_149.md Outdated Show resolved Hide resolved
docs/reference/r-releases/r-rev185_149.md Outdated Show resolved Hide resolved
docs/reference/r-releases/r-rev185_149.md Outdated Show resolved Hide resolved
docs/reference/r-releases/r-rev185_149.md Outdated Show resolved Hide resolved
@deusebio
Copy link
Contributor Author

@izmalk I have addressed the comments whenever it was sensible to do, while keeping consistency with the previous release notes for a similar look and feel.

I would leave it up to you and Andreia if we want to change the format. But when doing that, we should probably reformat also the other pages, always keeping a similar style across the documentation

@deusebio deusebio requested a review from izmalk November 19, 2024 08:52
Copy link
Contributor

@izmalk izmalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still see some room for improvement and a few comments that could be addressed, but nothing critical. Please check the summary for Kafka and ZooKeeper changes, the rest is optional.

docs/reference/r-releases/r-rev185_149.md Outdated Show resolved Hide resolved
docs/reference/r-releases/r-rev185_149.md Outdated Show resolved Hide resolved
docs/reference/r-releases/r-rev185_149.md Outdated Show resolved Hide resolved
Copy link

@grobbie grobbie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small changes needed, otherwise pretty good

docs/reference/r-releases/r-rev185_149.md Outdated Show resolved Hide resolved
docs/reference/r-releases/r-rev185_149.md Outdated Show resolved Hide resolved
docs/reference/r-releases/r-rev185_149.md Outdated Show resolved Hide resolved
Co-authored-by: Rob Gibbon <[email protected]>
Co-authored-by: Vladimir Izmalkov <[email protected]>
@deusebio deusebio requested a review from grobbie November 26, 2024 20:10
docs/reference/r-releases/r-rev185_149.md Outdated Show resolved Hide resolved
docs/reference/r-releases/r-rev185_149.md Outdated Show resolved Hide resolved
@deusebio deusebio requested a review from izmalk December 17, 2024 16:07
Copy link
Contributor

@izmalk izmalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the older comments but we need to take into account the newest changes in terminology.

docs/reference/r-releases/r-rev195_149.md Outdated Show resolved Hide resolved
docs/reference/r-releases/r-rev195_149.md Outdated Show resolved Hide resolved
docs/reference/r-releases/r-rev195_149.md Outdated Show resolved Hide resolved
docs/reference/r-releases/r-rev195_149.md Outdated Show resolved Hide resolved
docs/reference/r-releases/r-rev195_149.md Outdated Show resolved Hide resolved
docs/reference/r-releases/r-rev195_149.md Outdated Show resolved Hide resolved
docs/reference/r-releases/r-rev195_149.md Outdated Show resolved Hide resolved
docs/reference/r-releases/r-rev195_149.md Outdated Show resolved Hide resolved
docs/reference/r-releases/r-rev195_149.md Outdated Show resolved Hide resolved
docs/reference/r-releases/r-rev195_149.md Outdated Show resolved Hide resolved
@izmalk izmalk changed the title [DPE-5565] Release notes for 185/149 release [DPE-5565] Release notes for 195/149 release Dec 17, 2024
@deusebio deusebio requested a review from izmalk December 17, 2024 22:44
@deusebio
Copy link
Contributor Author

@izmalk thanks for spotting this. I have applied the changes, please check 85c249f

Copy link
Contributor

@izmalk izmalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the structure that we have now but I have a non-blocking suggestion for the naming of components.
Also, one Apache Kafka renaming is missing.

docs/reference/r-releases/r-rev195_149.md Outdated Show resolved Hide resolved
docs/reference/r-releases/r-rev195_149.md Outdated Show resolved Hide resolved
docs/reference/r-releases/r-rev195_149.md Outdated Show resolved Hide resolved
docs/reference/r-releases/r-rev195_149.md Outdated Show resolved Hide resolved
docs/reference/r-releases/r-rev195_149.md Outdated Show resolved Hide resolved
@deusebio deusebio requested a review from izmalk December 18, 2024 11:12
docs/reference/r-releases/r-rev195_149.md Outdated Show resolved Hide resolved
@deusebio
Copy link
Contributor Author

Content has been copied to Discourse here

@deusebio deusebio closed this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants