-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DPE-5565] Release notes for 195/149 release #263
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are some suggestions on how to improve the existing release notes. Feel free to apply them how you see fit. We can discuss the new structure on the sprint or after.
If no structural changes are wanted, then I'd recommend just adding empty lines after headings, renaming "General updates" sections, and moving some of its contents to the Notes section at the end.
@izmalk I have addressed the comments whenever it was sensible to do, while keeping consistency with the previous release notes for a similar look and feel. I would leave it up to you and Andreia if we want to change the format. But when doing that, we should probably reformat also the other pages, always keeping a similar style across the documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still see some room for improvement and a few comments that could be addressed, but nothing critical. Please check the summary for Kafka and ZooKeeper changes, the rest is optional.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small changes needed, otherwise pretty good
Co-authored-by: Rob Gibbon <[email protected]> Co-authored-by: Vladimir Izmalkov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for the older comments but we need to take into account the newest changes in terminology.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the structure that we have now but I have a non-blocking suggestion for the naming of components.
Also, one Apache Kafka renaming is missing.
Co-authored-by: Vladimir Izmalkov <[email protected]>
Co-authored-by: Vladimir Izmalkov <[email protected]>
Co-authored-by: Vladimir Izmalkov <[email protected]>
Co-authored-by: Vladimir Izmalkov <[email protected]>
Co-authored-by: Vladimir Izmalkov <[email protected]>
Co-authored-by: Vladimir Izmalkov <[email protected]>
Content has been copied to Discourse here |
Release notes for the upcoming release.
I would still like to tune a bit the community message and some other bits around. @grobbie maybe you can craft the main message for the community.