[DPE-2704] Integrate Kafka built from source #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmraul
reviewed
Oct 11, 2023
|
Well, I'd say both. I open the PR to make sure it works, but also we want to merge this such that we pack SNAPs using canonical provided artifacts. So, please do make also sure that updating the litearls is all is needed and - if so -give me thumbs up However, to merge this PR, we need to first merge this, release a new SNAP to 3/edge, and use that revision here. |
deusebio
force-pushed
the
dpe-2704-kafka-from-source
branch
from
d3988d7 to
19d7b8a
Compare
|
The snap has now been published to 3/edge with revision 21 here, so I have updated the PR which is now ready to be merged |
deusebio
force-pushed
the
dpe-2704-kafka-from-source
branch
from
19d7b8a to
48c5f63
Compare
zmraul
approved these changes
Oct 25, 2023
marcoppenheimer
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to test that the charm work well with a new snap revision that was built from source. That revision is currently sitting on
3/edge/dpe-2704-kafka-from-source