[DPE-2644] Test: network cut #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmraul
changed the base branch from
test/high-availability
to
test/dpe-2370-network-throttle
src/charm.py
Outdated
Comment on lines
207
to
217
| # NOTE: integration with kafka-broker-rack-awareness charm. | ||
| # Load current properties set in the charm workload and check | ||
| # if rack.properties file exists | ||
| # if rack.properties file exists. | ||
| # Also, check if listeners changed (IP change) | ||
| properties = safe_get_file(self.kafka_config.server_properties_filepath) | ||
| if properties and ( | ||
| self.kafka_config.rack_properties != [] | ||
| (self.kafka_config.rack_properties != [] or not self.kafka_config.listeners_updated) | ||
| and (set(self.kafka_config.server_properties) ^ set(properties)) | ||
| ): | ||
| self._on_config_changed(event) | ||
| self._restart(event) |
There was a problem hiding this comment.
suggestion: Could we move the self._on_config_changed(event) alone to right before the final self._set_status(Status.ACTIVE)?
There was a problem hiding this comment.
Not there, because the machine health check would return earlier. I can move it after broker active.
marcoppenheimer
approved these changes
Oct 6, 2023
zmraul
added a commit
that referenced
this pull request
Oct 6, 2023
* add network throttle test * [DPE-2644] Test: network cut (#139) * run _on_config_changed on update_status
deusebio
pushed a commit
that referenced
this pull request
Oct 16, 2023
* add network throttle test * [DPE-2644] Test: network cut (#139) * run _on_config_changed on update_status
zmraul
added a commit
that referenced
this pull request
Oct 17, 2023
* add network throttle test * [DPE-2644] Test: network cut (#139) * run _on_config_changed on update_status
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds network cut, which includes an IP change to the unit.
update_statustriggers.