Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPE-1965 - chore: use keytool snap app #130

Merged
merged 24 commits into from
Sep 25, 2023
Merged

DPE-1965 - chore: use keytool snap app #130

merged 24 commits into from
Sep 25, 2023

Conversation

marcoppenheimer
Copy link
Contributor

Depends on canonical/charmed-kafka-snap#27

Changes Made

chore: remove openjdk-17-jre-headless

  • Was originally installed to use keytool
  • Now usable through charmed-kafka.keytool

@marcoppenheimer marcoppenheimer changed the title chore: use keytool snap app DPE-1965 - chore: use keytool snap app Aug 30, 2023
src/snap.py Show resolved Hide resolved
Copy link
Contributor

@deusebio deusebio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as long as the tests pass

.github/workflows/ci.yaml Outdated Show resolved Hide resolved
@marcoppenheimer marcoppenheimer merged commit e09aa6f into main Sep 25, 2023
@marcoppenheimer marcoppenheimer deleted the chore/keytool branch September 25, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants