Replace redfish discover method #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done because redfish.discover_ssdp() discovers all available redfish services on the same network. This change checks if redfish is available by trying to login and check for the type of exception being raised. If RetriesExhaustedError is raised, it means that there is no redfish service. Resolves canonical#61.
The "on_remove_event" test was failing because after the relation between the ubuntu and hw-observer charm was removed, the ubuntu app would be active/idle and settle down before the cleanup activities were completed for hw-observer.
|
Unit tests failing on GH CI for test coverage reasons but doesn't fail on my local 😕
|
The failing is because of the coverage missing. |
jneo8
requested changes
Oct 2, 2023
Pjack
requested changes
Oct 2, 2023
|
Added unit tests for new function. |
jneo8
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
redfish.discover_ssdpmethod is replaced with a simple login call to the redfish service. If theRetriesExhaustedErrorexception is raised, we can infer that the redfish service isn't present on the system.This is done because the
redfish.discover_ssdpmethod finds all the redfish services on the same network which is not what we want.Fixes #61.