Replace instance to juju_unit for the metric joins
#377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deezzir
requested review from
Vultaire,
Pjack,
aieri,
samuelallan72,
jneo8,
gabrielcocenza and
sbparke
gabrielcocenza
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #367
The bug occurs because the
instancelabel is always set tolocalhost:10201. If you have multiple hosts, there might be duplicate drive names coming from different hosts; and because the label is not unique, there will be conflicts during the joins for some Smartctl graphs. So it's better to use thejuju_unitlabel which is guaranteed to be unique.