Fire SsaCLIControllerNotOK only if status is not OK and not NOT CONFIGURED #373
Conversation
Deezzir
requested review from
Vultaire,
Pjack,
aieri,
samuelallan72,
jneo8,
gabrielcocenza and
sbparke
| @@ -27,7 +27,7 @@ groups: | |||
| LABELS = {{ $labels }} | |||
|
|
|||
| - alert: SsaCLIControllerNotOK | |||
| expr: ssacli_controller_info{status != "OK"} == 1 | |||
| expr: ssacli_controller_info{status != "OK", status!="NOT CONFIGURED"} == 1 | |||
There was a problem hiding this comment.
This is not a valid Promql expression.
I will revert this PR.
Please, also add unit tests using the promtool
There was a problem hiding this comment.
It is a valid expression, I tested it
There was a problem hiding this comment.
How did you test this?
It won't break the query, but it always will return empty.
As far as I know you can't use two times status and expect this kind of behavior
You need to use regular expression and just use status once
There was a problem hiding this comment.
I tested with the same unit test you provided, I just didn't add it to the PR
There was a problem hiding this comment.
Incredibly it pass the unit tests if I set the NOT CONFIGURED. However this is very likely a promtool bug that we should file.
As showed above this kind of query will always return empty in Prometheus so it's useless in a real scenario
Fixes: #354