Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nouveau check and modprobe to install #359

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Add nouveau check and modprobe to install #359

merged 2 commits into from
Dec 3, 2024

Conversation

Deezzir
Copy link
Contributor

@Deezzir Deezzir commented Nov 30, 2024 •
edited
Loading

The PR fixes some issues with the current Nvidia driver install logic:

  • There is a check for nouveau drivers; if they are present, tell the operator. Otherwise, there is no point in installing Nvidia's closed-source drivers, as the Nvidia module slot is already occupied
  • Change the order of the arguments passed to ubuntu-drivers; see https://bugs.launchpad.net/ubuntu/+source/ubuntu-drivers-common/+bug/2090502 - hilarious
  • Run modprobe to load the installed drivers, ensuring a reboot is unnecessary.

The changes were tested on a testflinger machine.

Closes: #361

@Deezzir Deezzir requested a review from a team as a code owner November 30, 2024 03:01
gabrielcocenza
gabrielcocenza previously approved these changes Dec 2, 2024
View reviewed changes
src/hw_tools.py Outdated Show resolved Hide resolved
aieri
aieri requested changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@aieri aieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of suggestions, and we'll need unit tests (but I know you know this :))

src/hw_tools.py Outdated Show resolved Hide resolved
src/hw_tools.py Outdated Show resolved Hide resolved
@Deezzir Deezzir merged commit 174389c into canonical:main Dec 3, 2024
10 checks passed
@Deezzir Deezzir deleted the fix-driver-installation branch December 3, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrielcocenza gabrielcocenza gabrielcocenza approved these changes

@aieri aieri aieri approved these changes

@Pjack Pjack Awaiting requested review from Pjack Pjack is a code owner automatically assigned from canonical/soleng-reviewers

@samuelallan72 samuelallan72 Awaiting requested review from samuelallan72 samuelallan72 is a code owner automatically assigned from canonical/soleng-reviewers

@jneo8 jneo8 Awaiting requested review from jneo8 jneo8 is a code owner automatically assigned from canonical/soleng-reviewers

@rgildein rgildein Awaiting requested review from rgildein rgildein is a code owner automatically assigned from canonical/soleng-reviewers

@chanchiwai-ray chanchiwai-ray Awaiting requested review from chanchiwai-ray chanchiwai-ray is a code owner automatically assigned from canonical/soleng-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ubuntu-drivers --gpgpu flag order
3 participants
@Deezzir @aieri @gabrielcocenza