chore: reenable ops.main type hints #298
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimaqq
requested review from
Pjack,
aieri,
samuelallan72,
jneo8,
gabrielcocenza,
rgildein and
chanchiwai-ray
|
P.S. can be tested locally with: diff --git a/requirements.txt b/requirements.txt
index 0eeaba6..c8a95c5 100644
--- a/requirements.txt
+++ b/requirements.txt
@@ -1,6 +1,6 @@
cosl
distro
-ops >= 2.17.0
+git+https://github.com/canonical/operator.git@main#egg=ops
jinja2
redfish # requests is included in this
pydantic < 2 |
|
Hi @dimaqq I converted this PR to draft until 2.17 is not released, then we can convert it back and re-trigger CI. |
|
ops 2.17.0 is released, so I retriggered the CI and marked the PR as ready for review :) |
Pjack
previously approved these changes
Oct 4, 2024
|
Can't we unpin the ops library? |
samuelallan72
previously approved these changes
Oct 7, 2024
|
@dimaqq sorry, the CI is blocked on commits needing to be signed - could you gpg sign your commits (you can squash and force push to make it easier)? |
dimaqq
force-pushed
the
chore-reenable-type-hints-on-ops-main
branch
from
58700d3 to
9a137e0
Compare
|
Sorry I forgot to force-push earlier, here it is. |
dimaqq
force-pushed
the
chore-reenable-type-hints-on-ops-main
branch
2 times, most recently
from
bb6feab to
ef0a904
Compare
|
re the other CI fail, I'll be releasing a hotfix for pypi:juju today 🙇🏻 |
dimaqq
force-pushed
the
chore-reenable-type-hints-on-ops-main
branch
from
ef0a904 to
9d33835
Compare
|
The test fail is a mystery to me now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type hints are finally fixed for
ops.main()call in the upcoming ops release.The mypy config includes
warn_unused_ignoresin this repo, which means that using new ops will trigger an error soon.P.S. can only be merged when ops 2.17.0 is released.