refactor: Rename check_file_size #161
Merged
+45
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows for easier comprehension of the if statements that use this method. Extra details in docstring are also removed. Unit tests were also modified.
samuelallan72
requested changes
Feb 13, 2024
|
The juju 3.1 tests suddenly seem to be failing after the docstring change possibly due to something with upstream deps |
rgildein
previously approved these changes
Feb 14, 2024
sudeephb
approved these changes
Feb 14, 2024
samuelallan72
approved these changes
Feb 14, 2024
|
func test fix being made here: #163. Edit: PR not needed, fix was done upstream |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for easier comprehension of the if statements that use this method. Extra details in docstring are also removed (this info can be provided elsewhere in the docs). Due to the change in vocabulary, the True/ False return conditions are also switched.
Unit tests are also modified.