Fix: #147 (#148)

* Fix: #147 * update to 1m eval time * fix unit test eval time --------- Co-authored-by: honghan <[email protected]>
canonical · Jan 15, 2024 · b61b1c2 · b61b1c2
1 parent f064828
commit b61b1c2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/prometheus_alert_rules/general.yaml b/src/prometheus_alert_rules/general.yaml
@@ -3,7 +3,7 @@ groups:
   rules:
     - alert: CollectorFailed
       expr: '{__name__=~"(.*)_collector_failed"} == 1'
-      for: 0m
+      for: 1m
       labels:
         severity: error
       annotations:

diff --git a/tests/unit/test_alert_rules/test_general.yaml b/tests/unit/test_alert_rules/test_general.yaml
@@ -1,18 +1,18 @@
 rule_files:
   - ../../../src/prometheus_alert_rules/general.yaml
 
-evaluation_interval: 1m
+evaluation_interval: 2m
 
 tests:
-  - interval: 1m
+  - interval: 2m
     input_series:
       - series: ipmidcmi_collector_failed{instance="ubuntu-99", collector="ipmidcmi"}
         values: '1x15'
       - series: ipmisel_collector_failed{instance="ubuntu-99", collector="ipmisel"}
         values: '1x15'
 
     alert_rule_test:
-      - eval_time: 0m
+      - eval_time: 2m
         alertname: CollectorFailed
         exp_alerts:
           - exp_labels: