Update charm libs #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nsklikas
commented
Apr 19, 2024
nsklikas
commented
- Add workflow for updating the charm libs
- Update charm libs
- Start using cert_handler v1
- Remove peer relation, it was used only by cert_handler and v1 does not need it
nsklikas
force-pushed
the
update-charm-libs
branch
from
7503b54 to
aebca8d
Compare
BarcoMasile
previously approved these changes
Apr 22, 2024
nsklikas
force-pushed
the
update-charm-libs
branch
2 times, most recently
from
027681f to
3b3e8b2
Compare
|
The cert_handler lib has as bug, which causes it to fail on relation removal. The issue is caused by the fact that it tries to renew the certificate before deleting it (no idea why). I reported the issue at canonical/observability-libs#81 (comment). For some reason the issue happens consistently on |
BarcoMasile
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.