Implement the device authorization endpoint #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsklikas
commented
Feb 7, 2024
alesstimec
reviewed
Feb 8, 2024
The WriteAccessError is used to construct error responses as described in Section 5.2 of [RFC6749]. It is not limited to access token responses. Perhaps we should rename the function to Rfc6749TokenError.
nsklikas
force-pushed
the
IAM-653
branch
4 times, most recently
from
cb19a90 to
93b9238
Compare
|
I added docs to all public functions/packages and tried to fix as much as possible. I didn't make some of the style changes to keep consistency with the project style. |
This was referenced Feb 9, 2024
shipperizer
previously approved these changes
Feb 9, 2024
shipperizer
reviewed
Feb 9, 2024
alesstimec
approved these changes
Feb 12, 2024
BarcoMasile
previously approved these changes
Feb 12, 2024
nsklikas
dismissed stale reviews from BarcoMasile and shipperizer
via
6322f68
BarcoMasile
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the device authorization endpoint. The changes in this PR are based on the work done in ory#701 (a lot of the work is taken unchanged).
This PR is intended to implement the logic described in paragraphs RFC8628 - Section 3.1 and RFC8628 - Section 3.1.
These changes are tested using a hydra fork.
Even though this PR includes only ~half of the work needed to implement the device flow, it is still quite chunky. Perhaps I should try to break it down further.