Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a snap store icon for DCGM #42

Merged
merged 4 commits into from
Dec 2, 2024
Merged

Add a snap store icon for DCGM #42

merged 4 commits into from
Dec 2, 2024

Conversation

aieri
Copy link
Contributor

@aieri aieri commented Oct 16, 2024

This commit adds an icon for the snap. The icon is pulled from the
official logo[0] with the transparent background trimmed to 256x256px as
recommended in the snapcraft documentation[1]

[0] https://assets.nvidiagrid.net/ngc/logos/DCGM.png
[1] https://snapcraft.io/docs/snapcraft-yaml-schema#icon

Copy link
Contributor

@Deezzir Deezzir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocked while waiting for NVIDIA's explicit approval

This commit adds an icon for the snap. The icon is pulled from the
official logo[0] with the transparent background trimmed to 256x256px as
recommended in the snapcraft documentation[1]

[0] https://assets.nvidiagrid.net/ngc/logos/DCGM.png
[1] https://snapcraft.io/docs/snapcraft-yaml-schema#icon
@aieri aieri changed the title Add a charm store icon for DCGM Add a snap store icon for DCGM Oct 16, 2024
@aieri
Copy link
Contributor Author

aieri commented Nov 6, 2024

This is how the store will look after this change

image

image

@aieri
Copy link
Contributor Author

aieri commented Dec 2, 2024

We have received approval from NVIDIA via email from Edrick Wong. We can go ahead and merge the icon.

@aieri aieri merged commit a9152a4 into canonical:main Dec 2, 2024
5 checks passed
@aieri aieri deleted the add_icon branch December 2, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants