feat: add funcs part_has_slices and part_has_chisel_as_build_snap #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linostar
changed the title
linostar
changed the title
|
@mr-cal Ready for review. |
tigarmo
requested review from
mr-cal and
tigarmo
and removed request for
tigarmo
tigarmo
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is add two utility functions
part_has_slicesandpart_has_chisel_as_build_snapthat takes a dictionary (representing a part's data) as an argument and determine whether the part data has slices and whether it has chisel in build-snaps, respectively.Those functions are needed in Rockcraft, where we deal with part data dictionaries often, and converting those dictionaries to PartSpec objects will require extra code that has been already implemented internally in craft-parts.
Related work: #904