fix(rust_plugin): fix dependency validation logic #903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liushuyu
force-pushed
the
main
branch
2 times, most recently
from
50470a4
to
8340bb0
Compare
lengau
requested changes
Nov 19, 2024
... if "rust-deps" is in the "after" property (i.e. the user wants to install the Rust toolchain themselves)
Now the logic goes like this: * If channel is "none": validates if cargo and rustc are installed * If channel is other values: validates if rustup is installed * If "after" contains "rust-deps": validates if cargo and rustc are installed * If "after" contains "rust-deps" and also channel is not "none": throws error as this is not a supported configuration
... dependency validation logic
mr-cal
approved these changes
Nov 21, 2024
|
Do I need to rebase the changes for this pull request to merge cleanly? |
No need, I can merge and land this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the dependency validation logic regarding the "rust-deps" situation. If
rustupis installed, thencargoandrustcwill return an error code of1instead of127if no default toolchain is installed (becausecargoandrustcwill be shims generated byrustup).Two more tests are added to verify this new validation logic.
Should fix #890.