Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the fips configuation check #276

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

alanmcanonical
Copy link

According to the building log of lp builder, the fips database is not updated during 001-extra-packages.chroot. So we try to remove the inside check for adding fips ppa into source list and assume that any lp building is granted access to current ppa internally

Copy link
Member

@Meulengracht Meulengracht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for looking into the LP build issues. For context: The PPA is injected into the build container, however when we chroot for the hooks, the PPA is not propagated into the chroot, giving weird results.

So, we need to add the FIPS PPA in any case as long as it's a FIPS build, not just for the local one. The only difference between the local build now and the LP is whether we have the local fips.conf file for providing credentials. The LP builders should not need this.

@Meulengracht Meulengracht merged commit 434ada1 into canonical:core24 Nov 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants