-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
static: create device nodes if nvidia driver is loaded #259
static: create device nodes if nvidia driver is loaded #259
Conversation
deea8f5
to
0fd2a6c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
static/usr/bin/nvidia-create-device
Outdated
@@ -0,0 +1,11 @@ | |||
#!/bin/sh -eux |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why cannot we just ship ub-create-device?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem with it is that it depends on the nvidia driver version, so you get different version for 535, 550, etc. The real solution would be to let the kernel add udev rules to the system, but we are not there yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is this right? https://github.com/canonical/nvidia-graphics-drivers/blob/560/debian/device-create/ub-device-create.c
That file has not changed for 4 years.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I actually thought this was coming from nvidia. I've changed this now.
0fd2a6c
to
b1ec208
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the order of calls to modprobe and Nvidia device create program relevant?
Import the 71-nvidia.rules file shipped by nvidia-kernel-common-* and the ancillary ub-device-create executable that creates some device nodes when the nvidia kernel module is loaded.
b1ec208
to
4f006f5
Compare
Not sure, but I'm not changing the order of the udev rules here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the changes.
Fwiw, this has been tested on a device with nvidia GPU and nvidia modules. |
Do the same actions as the 71-nvidia.rules files shipped by nvidia-kernel-common-* in case the nvidia driver has been loaded in the system.