-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
static: mount some directories from initramfs #245
Merged
alfonsosanchezbeato
merged 2 commits into
canonical:main
from
alfonsosanchezbeato:mount-in-initrd
Oct 9, 2024
Merged
static: mount some directories from initramfs #245
alfonsosanchezbeato
merged 2 commits into
canonical:main
from
alfonsosanchezbeato:mount-in-initrd
Oct 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a prerequisite for canonical/core-initrd#262 |
Moving to ready for review as we will want this before any other change. |
This needs a rebase? |
Meulengracht
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be proposed for core24 as well
We want to mount some folders from the initramfs as they are a requisite to mount the kernel snap from initramfs: - /snap is the root of the mountpoints for the kernel snap and kernel-modules components - /var/lib/snapd contains the drivers tree and the snap and component files - /var/snap might contain dynamically generated kernel modules, and we want the links from the drivers tree to be valid since the moment we switch root.
alfonsosanchezbeato
force-pushed
the
mount-in-initrd
branch
from
September 20, 2024 17:17
290c984
to
45632cd
Compare
Rebased, also updated actions to fix the tests |
I'll propose for core24 when approved. |
valentindavid
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to mount /snap and /var/lib/snapd from the initramfs as they are a requisite to mount the kernel snap from initramfs.