test: simplify error comparison logic

canonical · Feb 14, 2024 · 9d5fdbe · 9d5fdbe
1 parent 8d85c30
commit 9d5fdbe
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/internal/setup/setup_test.go b/internal/setup/setup_test.go
@@ -1193,6 +1193,9 @@ var sliceKeyTests = []struct {
 }, {
 	input: "-foo_bar",
 	err:   `invalid slice reference: "-foo_bar"`,
+}, {
+	input: "foo+_bar",
+	expected: setup.SliceKey{Package: "foo+", Slice: "bar"},
 }, {
 	input:    "foo_slice123",
 	expected: setup.SliceKey{Package: "foo", Slice: "slice123"},
@@ -1201,7 +1204,7 @@ var sliceKeyTests = []struct {
 func (s *S) TestParseSliceKey(c *C) {
 	for _, test := range sliceKeyTests {
 		key, err := setup.ParseSliceKey(test.input)
-		if err != nil || test.err != "" {
+		if test.err != "" {
 			c.Assert(err, ErrorMatches, test.err)
 			continue
 		}