Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(24.04): add slice for libnginx-mod-http-headers-more-filter #437

Conversation

norrisjeremy
Copy link

@norrisjeremy norrisjeremy commented Dec 17, 2024

Proposed changes

feat(24.04): add slice for libnginx-mod-http-headers-more-filter

Related issues/PRs

#438

Forward porting

Checklist

Additional Context

$ chisel cut --release chisel-releases/ --root foo base-files_var base-passwd_data libnginx-mod-http-headers-more-filter_modules
2024/12/17 03:38:31 Processing chisel-releases/ release...
2024/12/17 03:38:45 Selecting slices...
2024/12/17 03:38:45 Fetching ubuntu 24.04 noble suite details...
2024/12/17 03:38:46 Release date: Thu, 25 Apr 2024 15:10:33 UTC
2024/12/17 03:38:46 Fetching index for ubuntu 24.04 noble main component...
2024/12/17 03:38:46 Fetching index for ubuntu 24.04 noble universe component...
2024/12/17 03:38:46 Fetching ubuntu 24.04 noble-security suite details...
2024/12/17 03:38:46 Release date: Tue, 17 Dec 2024  5:05:19 UTC
2024/12/17 03:38:46 Fetching index for ubuntu 24.04 noble-security main component...
2024/12/17 03:38:46 Fetching index for ubuntu 24.04 noble-security universe component...
2024/12/17 03:38:46 Fetching ubuntu 24.04 noble-updates suite details...
2024/12/17 03:38:46 Release date: Tue, 17 Dec 2024  8:54:19 UTC
2024/12/17 03:38:46 Fetching index for ubuntu 24.04 noble-updates main component...
2024/12/17 03:38:46 Fetching index for ubuntu 24.04 noble-updates universe component...
2024/12/17 03:38:46 Fetching pool/main/b/base-files/base-files_13ubuntu10.1_amd64.deb...
2024/12/17 03:38:46 Fetching pool/main/b/base-passwd/base-passwd_3.6.3build1_amd64.deb...
2024/12/17 03:38:46 Fetching pool/main/g/glibc/libc6_2.39-0ubuntu8.3_amd64.deb...
2024/12/17 03:38:46 Fetching pool/main/libx/libxcrypt/libcrypt1_4.4.36-4build1_amd64.deb...
2024/12/17 03:38:46 Fetching pool/universe/libn/libnginx-mod-http-headers-more-filter/libnginx-mod-http-headers-more-filter_0.37-2build1_amd64.deb...
2024/12/17 03:38:46 Fetching pool/main/n/nginx/nginx_1.24.0-2ubuntu7.1_amd64.deb...
2024/12/17 03:38:46 Fetching pool/main/p/pcre2/libpcre2-8-0_10.42-4ubuntu2_amd64.deb...
2024/12/17 03:38:46 Fetching pool/main/o/openssl/libssl3t64_3.0.13-0ubuntu3.4_amd64.deb...
2024/12/17 03:38:46 Fetching pool/main/n/nginx/nginx-common_1.24.0-2ubuntu7.1_all.deb...
2024/12/17 03:38:46 Fetching pool/main/z/zlib/zlib1g_1.3.dfsg-3.1ubuntu2.1_amd64.deb...
2024/12/17 03:38:46 Extracting files from package "base-files"...
2024/12/17 03:38:46 Extracting files from package "base-passwd"...
2024/12/17 03:38:46 Extracting files from package "libc6"...
2024/12/17 03:38:46 Extracting files from package "libcrypt1"...
2024/12/17 03:38:46 Extracting files from package "libnginx-mod-http-headers-more-filter"...
2024/12/17 03:38:46 Extracting files from package "nginx"...
2024/12/17 03:38:46 Extracting files from package "libpcre2-8-0"...
2024/12/17 03:38:46 Extracting files from package "libssl3t64"...
2024/12/17 03:38:46 Extracting files from package "nginx-common"...
2024/12/17 03:38:46 Extracting files from package "zlib1g"...
$ sudo chroot foo nginx -t
nginx: the configuration file /etc/nginx/nginx.conf syntax is ok
nginx: configuration file /etc/nginx/nginx.conf test is successful

Copy link

Diff of dependencies:

slices/libnginx-mod-http-headers-more-filter.yaml
@@ -1,2 +1,2 @@
 libc6
-nginx-abi-1.24.0-1
+nginx
slices/nginx.yaml
@@ -1,4 +1,3 @@
-iproute2
 libc6
 libcrypt1
 libpcre2-8-0

@norrisjeremy norrisjeremy force-pushed the libnginx-mod-http-headers-more-filter_noble branch from 8d10c8d to f3dd5bd Compare December 17, 2024 12:44
Copy link
Collaborator

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for noting the need for nginx-common_modules

Copy link

@clay-lake clay-lake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to #438, this looks good. Thank you.

@cjdcordeiro cjdcordeiro merged commit 7388765 into canonical:ubuntu-24.04 Dec 18, 2024
14 checks passed
@norrisjeremy norrisjeremy deleted the libnginx-mod-http-headers-more-filter_noble branch December 18, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants