feat(24.04): add gnutls-bin and dependencies #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Diff of dependencies: |
rebornplusplus
approved these changes
Sep 20, 2024
Comment on lines
+3
to
+5
| systems: | ||
| - -ubuntu-24.04-ppc64le | ||
| - -ubuntu-24.04-s390x |
There was a problem hiding this comment.
nit: a comment would be nice here why you would want to skip these systems.
cjdcordeiro
requested changes
Sep 30, 2024
Comment on lines
+14
to
+21
| /usr/bin/certtool: | ||
| /usr/bin/danetool: | ||
| /usr/bin/gnutls-cli: | ||
| /usr/bin/gnutls-cli-debug: | ||
| /usr/bin/gnutls-serv: | ||
| /usr/bin/ocsptool: | ||
| /usr/bin/p11tool: | ||
| /usr/bin/psktool: |
There was a problem hiding this comment.
You're only testing a couple of these, but could you please test them all? We need to guarantee that they are minimally functional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add gnutls-bin tools and missing dependencies
Forward porting
This can be proposed for 24.10 if this is approved
Checklist