Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(24.04) add adduser slice #305

Draft
wants to merge 5 commits into
base: ubuntu-24.04
Choose a base branch
from

Conversation

linostar
Copy link

@linostar linostar commented Aug 2, 2024

Proposed changes

Adds adduser slice to 24.04.

Related issues/PRs

N/A

Forward porting

N/A

Checklist

Additional Context

Copy link

github-actions bot commented Aug 2, 2024

Diff of dependencies:

slices/adduser.yaml
@@ -1 +1,4 @@
+bsdutils
+libperl5.38t64
 passwd
+perl-base

tests/spread/integration/adduser/task.yaml Outdated Show resolved Hide resolved
chroot "$rootfs"

test -f /etc/passwd
adduser --quiet --system testuser
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this working? Isn't adduser a perl script? I don't see perl being included/chiselled anywhere

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. This was working before because adduser was running outside of the chroot env. We need perl slice first before this test passes.

@linostar linostar force-pushed the feat-24.04-adduser branch from 1def4a2 to 3602152 Compare August 2, 2024 13:26
@linostar linostar force-pushed the feat-24.04-adduser branch from 3602152 to 56e3a67 Compare August 2, 2024 13:30
@linostar
Copy link
Author

linostar commented Aug 2, 2024

Depends on #291.

@linostar
Copy link
Author

This is waiting for #334 to be merged first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants