feat(24.04): add vim and vim-tiny slices #301
Conversation
|
Diff of dependencies: |
| essential: | ||
| - libc6_libs | ||
| - libexpat1_libs | ||
| - libpython3.12-stdlib_core |
There was a problem hiding this comment.
Would you please double-check why we need libpython3.12-stdlib? I am guessing libpython3.12-stdlib is a dependency of libpython3.12t64 because of the copyright paths. But I could be wrong.
lrwxrwxrwx root/root 0 2024-07-31 17:43 ./usr/share/doc/libpython3.12t64 -> libpython3.12-stdlib
Does the shared objects in this package access any python libs? ldd didn't produce anything like that:
# ldd ./usr/lib/x86_64-linux-gnu/libpython3.12.so.1.0
linux-vdso.so.1 (0x00007fff4bd6c000)
libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007d44f1f83000)
libz.so.1 => /lib/x86_64-linux-gnu/libz.so.1 (0x00007d44f1f67000)
libexpat.so.1 => not found
libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007d44f13ee000)
/lib64/ld-linux-x86-64.so.2 (0x00007d44f2070000)
There was a problem hiding this comment.
Without going into the source, strings shows that many of the libraries in libpython3.12-stdlib are referenced in libpython3.12t64. Im guessing the dependency here is on python libraries that don't show up with ldd
| @@ -0,0 +1,12 @@ | |||
| package: libpython3.12t64 | |||
|
|
|||
| slices: | |||
There was a problem hiding this comment.
Is it possible to add a copyright slice with the following path?
/usr/share/doc/libpython3.12t64
Have to check the deps though. It's a symlink, might need other package to fill in the target path.
| data: | ||
| contents: | ||
| /usr/bin/helpztags: |
There was a problem hiding this comment.
I am not sure if data is the appropriate slice name here. helpztags is a perl script:
#!/usr/bin/perl
#
# helpztags generates tags for Vim helpfiles, for both .txt and .txt.gz files
# Author: Jakub Turski <[email protected]>
# Artur R. Czechowski <[email protected]>
# Version: 0.4
# Please use following command for generate a manual file:
# pod2man -c "User Commands" -s 1 -q none -r "vim 6.2" -d "September 2003" helpztags helpztags.1
=head1 NAME
helpztags - generate the help tags file for directory
...How about bins?
| config: | ||
| contents: | ||
| /etc/vim/vimrc: | ||
| /usr/share/vim/vim91/debian.vim: |
There was a problem hiding this comment.
I am a bit sceptic on whether or not we should include this file in config. It seems quite specific for Debian.
Having said that, if we do include it upon agreement, would you kindly omit the vim91 word with vim*?
| - vim-common_config | ||
| - vim-tiny_config | ||
| contents: | ||
| /usr/bin/vi: {symlink: /usr/bin/vim.tiny} |
There was a problem hiding this comment.
Good call not making the view, editor symlinks! 👍
| - vim-common_config | ||
| - vim-tiny_config | ||
| contents: | ||
| /usr/bin/vi: {symlink: /usr/bin/vim.tiny} |
There was a problem hiding this comment.
Coming back to this again, vim also tries to create a symlink from vi:
update-alternatives --install /usr/bin/vi vi /usr/bin/vim.basic 30Perhaps we should ignore making the vi symlink?
| - vim-common_config | ||
| - vim-runtime_plugins | ||
| contents: | ||
| /usr/bin/vim: {symlink: /usr/bin/vim.basic} |
There was a problem hiding this comment.
This is fine, until we have packages like vim-gtk3 coming in where it demands with a higher priority that vim should point to vim.gtk3:
update-alternatives --install /usr/bin/vim vim /usr/bin/vim.gtk3 50
Thoughts on how we should address the vi and vim symlinks?
There was a problem hiding this comment.
I think we have a similar issue with symlinking sh to various shells. Maybe we should have an explicit symlink slice in the future so we could have both bash_bins and dash_bins installed, but specify dash as sh via dash_links or dash_sh
| - vim-common_config | ||
| - vim-runtime_plugins | ||
| contents: | ||
| /usr/bin/vim: {symlink: /usr/bin/vim.basic} |
There was a problem hiding this comment.
I think we have a similar issue with symlinking sh to various shells. Maybe we should have an explicit symlink slice in the future so we could have both bash_bins and dash_bins installed, but specify dash as sh via dash_links or dash_sh
| essential: | ||
| - libc6_libs | ||
| - libexpat1_libs | ||
| - libpython3.12-stdlib_core |
There was a problem hiding this comment.
Without going into the source, strings shows that many of the libraries in libpython3.12-stdlib are referenced in libpython3.12t64. Im guessing the dependency here is on python libraries that don't show up with ldd
Proposed changes
Add vim and vim-tiny slices for 24.04
Related issues/PRs
None
Forward porting
N/A
Checklist
Additional Context
Tested vi/vim interactive manually, and tested vi/vim running scripts properly with spread tests.