Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slice definition for iputils-ping #283

Conversation

ElgmiliAbdeljalil
Copy link

Proposed changes

Related issues/PRs

Forward porting

Testing

# Example:
#  chisel cut ... --root <path> <pkg>_<proposed-slice>
#  sudo chroot <path> <app>

Checklist

Additional Context

@cjdcordeiro cjdcordeiro requested a review from a team July 19, 2024 08:54
@cjdcordeiro cjdcordeiro self-assigned this Jul 19, 2024
Copy link
Collaborator

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @ElgmiliAbdeljalil

Could you please sign the CLA so the check passes?

@rebornplusplus
Copy link
Member

TODO: The base branch needs to be changed. It's currently main.

Which release are you adding the changes for @ElgmiliAbdeljalil? 24.04?

@clay-lake
Copy link

Hi @ElgmiliAbdeljalil

Thanks for the contribution. I wanted to check in and ask if you could sign the CLA?

@ElgmiliAbdeljalil
Copy link
Author

ElgmiliAbdeljalil commented Aug 27, 2024 via email

@cjdcordeiro
Copy link
Collaborator

Thanks ;)

In the meantime, I'm gonna close this since it has been opened against the wrong branch. So a new PR needs to be raised against the correct ubuntu release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants