-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(spread): support slice testing through Spread #281
ci(spread): support slice testing through Spread #281
Conversation
Diff of dependencies: slices/libpython3.12-stdlib.yaml@@ -3,6 +3,7 @@
libcrypt1
libdb5.3t64
libffi8
+libgcc-s1
liblzma5
libncursesw6
libpython3.12-minimal
@@ -10,6 +11,5 @@
libsqlite3-0
libtinfo6
media-types
-mime-support
netbase
tzdata |
@rebornplusplus shouldn't other tests have been triggered? there's a change to a slice in this PR... |
ah ok! found the reason: https://github.com/canonical/chisel-releases/actions/runs/9908076533 makes sense. I'll "Block" this just so we remember to re-run the tests once we merge the PR for |
Sounds like a plan. Let's do that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you!
I would wait for the two separate commits - one for the fix and the other for CI.
2c6b59f
to
0a0206c
Compare
0a0206c
to
026583b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of nitpicks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Cris, this is looking good. I see that the CI is failing because it is timing out, I triggered another run to see if it was a transient issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Proposed changes
needs #280
This PR adds the Spread configurations to this branch. It also adds a couple of initial tests for existing package slices.
In addition, it also fixes a missing dependency for Python3.12 on armhf (identified via the tests 😄 )
Related issues/PRs
#280
Testing
Tested the execution of this workflow here:
Checklist