Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(spread): support slice testing through Spread #281

Conversation

cjdcordeiro
Copy link
Collaborator

Proposed changes

needs #280

This PR adds the Spread configurations to this branch. It also adds a couple of initial tests for existing package slices.

In addition, it also fixes a missing dependency for Python3.12 on armhf (identified via the tests 😄 )

Related issues/PRs

#280

Testing

Tested the execution of this workflow here:

Checklist

@cjdcordeiro cjdcordeiro self-assigned this Jul 12, 2024
Copy link

github-actions bot commented Jul 12, 2024

Diff of dependencies:

slices/libpython3.12-stdlib.yaml
@@ -3,6 +3,7 @@
 libcrypt1
 libdb5.3t64
 libffi8
+libgcc-s1
 liblzma5
 libncursesw6
 libpython3.12-minimal
@@ -10,6 +11,5 @@
 libsqlite3-0
 libtinfo6
 media-types
-mime-support
 netbase
 tzdata

@cjdcordeiro
Copy link
Collaborator Author

@rebornplusplus shouldn't other tests have been triggered? there's a change to a slice in this PR...

@cjdcordeiro
Copy link
Collaborator Author

@rebornplusplus shouldn't other tests have been triggered? there's a change to a slice in this PR...

ah ok! found the reason: https://github.com/canonical/chisel-releases/actions/runs/9908076533

makes sense. I'll "Block" this just so we remember to re-run the tests once we merge the PR for main

@cjdcordeiro cjdcordeiro added the Blocked Waiting for something external label Jul 12, 2024
@rebornplusplus
Copy link
Member

@rebornplusplus shouldn't other tests have been triggered? there's a change to a slice in this PR...

ah ok! found the reason: https://github.com/canonical/chisel-releases/actions/runs/9908076533

makes sense. I'll "Block" this just so we remember to re-run the tests once we merge the PR for main

Sounds like a plan. Let's do that.

@cjdcordeiro cjdcordeiro removed the Blocked Waiting for something external label Jul 16, 2024
Copy link
Member

@rebornplusplus rebornplusplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

I would wait for the two separate commits - one for the fix and the other for CI.

slices/libpython3.12-stdlib.yaml Show resolved Hide resolved
@cjdcordeiro cjdcordeiro force-pushed the ROCKS-1262/add-spread-tests-24.04 branch 2 times, most recently from 2c6b59f to 0a0206c Compare July 17, 2024 06:15
@cjdcordeiro cjdcordeiro force-pushed the ROCKS-1262/add-spread-tests-24.04 branch from 0a0206c to 026583b Compare July 17, 2024 06:17
@cjdcordeiro cjdcordeiro requested a review from a team July 17, 2024 06:19
@cjdcordeiro cjdcordeiro added the Priority Look at me first label Jul 17, 2024
Copy link

@linostar linostar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of nitpicks.

tests/spread/lib/install-slices Show resolved Hide resolved
Copy link
Collaborator

@letFunny letFunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Cris, this is looking good. I see that the CI is failing because it is timing out, I triggered another run to see if it was a transient issue.

spread.yaml Show resolved Hide resolved
@cjdcordeiro
Copy link
Collaborator Author

@letFunny @linostar ty. your comments are addressed in bf19889

@cjdcordeiro cjdcordeiro requested review from linostar and letFunny July 19, 2024 08:43
Copy link

@linostar linostar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Collaborator

@letFunny letFunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cjdcordeiro cjdcordeiro merged commit 4373954 into canonical:ubuntu-24.04 Jul 23, 2024
13 checks passed
@cjdcordeiro cjdcordeiro deleted the ROCKS-1262/add-spread-tests-24.04 branch July 23, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority Look at me first
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants