feat(24.04): netplan.io and dependencies #276
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Diff of dependencies: slices/iproute2.yaml@@ -1,5 +1,3 @@
-debconf
-debconf-2.0
libbpf1
libc6
libcap2slices/netplan.io.yaml@@ -4,9 +4,9 @@
libnetplan1
libsystemd0
netplan-generator
-python3
python3-dbus
python3-netifaces
python3-netplan
python3-yaml
+python3.12
systemdslices/python3-cffi-backend.yaml@@ -1,3 +1,3 @@
libc6
libffi8
-python3
+python3.12slices/python3-dbus.yaml@@ -1,4 +1,4 @@
libc6
libdbus-1-3
libglib2.0-0t64
-python3
+python3.12slices/python3-netifaces.yaml@@ -1,2 +1,2 @@
libc6
-python3
+python3.12slices/python3-netplan.yaml@@ -1,4 +1,4 @@
libc6
libnetplan1
-python3
python3-cffi-backend
+python3.12slices/python3-yaml.yaml@@ -1,3 +1,3 @@
libc6
libyaml-0-2
-python3
+python3.12 |
Meulengracht
force-pushed
the
slices/netplan
branch
from
f7f03fd to
525fa95
Compare
Meulengracht
force-pushed
the
slices/netplan
branch
from
525fa95 to
65cc88e
Compare
Meulengracht
force-pushed
the
slices/netplan
branch
from
65cc88e to
68ad9a9
Compare
3 tasks
Meulengracht
force-pushed
the
slices/netplan
branch
3 times, most recently
from
8c7f5ed to
fad5cdc
Compare
Meulengracht
force-pushed
the
slices/netplan
branch
from
025479b to
83c89fe
Compare
Meulengracht
commented
Aug 30, 2024
cjdcordeiro
requested changes
Sep 27, 2024
|
|
||
| # test some basic commands and against loopback that | ||
| # we can kinda expect is there | ||
| ip link | grep "LOOPBACK,UP" |
There was a problem hiding this comment.
can you please also test the other binaries being installed? I know it might be tedious, but that's the only way we can ensure the slice has all it needs for them to behave properly
| @@ -0,0 +1,12 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
are any of the scripts testable?
slices/python3-yaml.yaml
Outdated
There was a problem hiding this comment.
could you please add some tests for these python-* SDFs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add netplan and it's dependencies. Netplan is a bit useless without other networking daemons up and running (i.e systemd-networkd), and it's also quite useless without udev running. The app itself is working and the only errors it throws are due to either a chroot'ed environment or because some other system service is missing.
Testing
Checklist
Additional Context
This is based on top of #274 since netplan requires systemd and mount libraries.