-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(24.04): reorganise ca-certificates slice(s) #266
fix(24.04): reorganise ca-certificates slice(s) #266
Conversation
Diff of dependencies: slices/ca-certificates.yaml@@ -1,3 +1,2 @@
-debconf
-debconf-2.0
openssl
+sed |
aa0c16c
to
f45dba9
Compare
f45dba9
to
f2eee66
Compare
f2eee66
to
0417cb0
Compare
0417cb0
to
77025ed
Compare
a853570
to
0a06b57
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. LGTM. if @rebornplusplus and @javierdelapuente approve, I'll merge it
Not sure if related to this PR, or the way I am doing it is different from the way it is really done while building a rock. I am trying to use I get the following error (I think the other cert.pem file comes as a dependency of python3-venv):
Checking inside lxc I see:
Will this also happen when rockcraft gets the chiselled ca-certificates_data-with-certs? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry to go back and forth on this. It looks quite nice. Just have one concern about the ca-certificates.conf
I mentioned below.
In general, I see two options about the whole ca-certificates
offering:
- The
data
slice provides the bundle, individual default certs and the config file. Pro: this is a standard offering and doesn't break anything. Con: the slice doubles in size and then some, for the config file. Another slice (name TBD) provides only the bundle and nothing else. - As it is now, the
data
slice provides only the bundle and another slice provides the bundle, config and the individual default certs.
Re-considering it, I feel much more inclined to having option 1 since most of the users would not mind the small extra weight in data
slice as long it doesn't break and provide a smooth experience. Let me know what you think!
Hi @javierdelapuente, I think the other In any case, no I don't think merging the slices would fix this issue. I reckon there's a need to dive deep and see where the symlink is coming from and/or where it's being modified. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed and tested it with James. LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice to me. Only left a few suggestions about the comments.
Co-authored-by: Rafid Bin Mostofa <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good from me! Can be merged after another maintainer's approval.
--------- Co-authored-by: Rafid Bin Mostofa <[email protected]> Co-authored-by: Cristovao Cordeiro <[email protected]>
--------- Co-authored-by: Rafid Bin Mostofa <[email protected]> Co-authored-by: Cristovao Cordeiro <[email protected]>
--------- Co-authored-by: Rafid Bin Mostofa <[email protected]> Co-authored-by: Cristovao Cordeiro <[email protected]>
Proposed changes
The script
update-ca-certificates
and its corresponding config file/etc/ca-certificates.conf
is added to the SDF ofca-certificates
.Related issues/PRs
ROCKS-994
Forward porting
Not applicable.
Checklist