-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
24.04/add some libboost 1.83 slices #245
24.04/add some libboost 1.83 slices #245
Conversation
Diff of dependencies: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Just to notice coroutine requires libgcc-s1 for armhf machines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for the PR! The slices mostly look good. I reckon there are a few linting issues in this PR. It should be good to merge after those are fixed. Check the CI.
add coroutine1 comment about libgcc-s1 dependency for armhf architecture
sort essential dependencies
sort esssential dependencies
d34c499
to
d060565
Compare
I sent fixups, but the CI is failing, asking to sort on files I didn't changed. Maybe the CI should only test the files that are in the PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@endersonmaia could you pls double check your email in LP? The CLA check is failing
Weird, it was passing before, right? I'll try to see what's going on. |
Everything looks ok with my LP account. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was indeed passing before and I can see your LP account has the right email. I can also see you are in the CLA list. This might be a glitch, so let's proceed anyway
Proposed changes
As part of the issue #244 , this PR will add some of the packages.
Related issues/PRs
#224
Testing
Checklist