Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(24.04): add slice for busybox #159

Merged
merged 7 commits into from
May 16, 2024
Merged

feat(24.04): add slice for busybox #159

merged 7 commits into from
May 16, 2024

Conversation

norrisjeremy
Copy link

@norrisjeremy norrisjeremy commented Feb 29, 2024

Proposed changes

feat(24.04): add slice for busybox

Related issues/PRs

#155

Forward porting

384bc69
7fc4a3d
76ac1e5
06c868b
8fac057
29d8e6b

Testing

$ chisel cut --release chisel-releases/ --root foo busybox_bins base-files_base
2024/02/29 10:12:09 Processing chisel-releases/ release...
2024/02/29 10:12:09 Selecting slices...
2024/02/29 10:12:09 Fetching ubuntu 24.04 noble suite details...
2024/02/29 10:12:09 Release date: Thu, 29 Feb 2024 15:03:37 UTC
2024/02/29 10:12:09 Fetching index for ubuntu 24.04 noble main component...
2024/02/29 10:12:09 Fetching index for ubuntu 24.04 noble universe component...
2024/02/29 10:12:09 Fetching ubuntu 24.04 noble-security suite details...
2024/02/29 10:12:09 Release date: Thu, 04 Jan 2024 18:43:12 UTC
2024/02/29 10:12:09 Fetching index for ubuntu 24.04 noble-security main component...
2024/02/29 10:12:09 Fetching index for ubuntu 24.04 noble-security universe component...
2024/02/29 10:12:09 Fetching ubuntu 24.04 noble-updates suite details...
2024/02/29 10:12:09 Release date: Thu, 04 Jan 2024 18:43:15 UTC
2024/02/29 10:12:09 Fetching index for ubuntu 24.04 noble-updates main component...
2024/02/29 10:12:09 Fetching index for ubuntu 24.04 noble-updates universe component...
2024/02/29 10:12:09 Fetching pool/main/b/base-files/base-files_13ubuntu7_amd64.deb...
2024/02/29 10:12:09 Fetching pool/main/g/glibc/libc6_2.39-0ubuntu2_amd64.deb...
2024/02/29 10:12:09 Fetching pool/universe/b/busybox/busybox_1.36.1-6ubuntu1_amd64.deb...
2024/02/29 10:12:09 Extracting files from package "base-files"...
2024/02/29 10:12:09 Extracting files from package "libc6"...
2024/02/29 10:12:09 Extracting files from package "busybox"...
$ sudo chroot foo /usr/bin/busybox echo test                                            
test

Checklist

Additional Context

@norrisjeremy
Copy link
Author

@cjdcordeiro @rebornplusplus Can this be merged soon?

Copy link
Member

@rebornplusplus rebornplusplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link

Diff of dependencies:
None found.


Copy link
Collaborator

@zhijie-yang zhijie-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@norrisjeremy
Copy link
Author

@cjdcordeiro @rebornplusplus What's the hold-up on getting this merged? It's been languishing for over a month.

@linostar
Copy link

@norrisjeremy can you please sign the CLA so we can merge your PR?

@linostar
Copy link

linostar commented May 16, 2024

@norrisjeremy can you please sign the CLA so we can merge your PR?

Nevermind, you already signed it. Can you please recommit (and force-push) with your github account that signed the CLA so that the CLA check passes.

@cjdcordeiro cjdcordeiro self-assigned this May 16, 2024
Copy link
Collaborator

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@cjdcordeiro cjdcordeiro merged commit 6261da7 into canonical:ubuntu-24.04 May 16, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants